Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

fix lu build bug when training empty intents#643

Merged
feich-ms merged 2 commits intomastermicrosoft/botframework-cli:masterfrom
feich/lubuildFixmicrosoft/botframework-cli:feich/lubuildFixCopy head branch name to clipboard
Mar 9, 2020
Merged

fix lu build bug when training empty intents#643
feich-ms merged 2 commits intomastermicrosoft/botframework-cli:masterfrom
feich/lubuildFixmicrosoft/botframework-cli:feich/lubuildFixCopy head branch name to clipboard

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Mar 9, 2020

Fix two bugs:

  1. fix bug Unable to successfully publish to LUIS (sometimes) BotFramework-Composer#2195. Luis API will throw exception when training lu file with empty intents(with no utterances and patterns). This PR removes the empty intents before creating and training/publishing lu models. Meanwhile, it will log out a messages such as [WARN]: empty intent(s) # A, # B are filtered when handling luis application
  2. fix invalid model info error message [WARN]: Invalid model info found. Skipping "> !# @enableSections = true which was false error. enableSections is used in luParser.js. The fix here is to avoid the error message.

Copy link
Contributor

@boydc2014 boydc2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @munozemilio i'm approving and merging this, since it's a P0 bug in composer on this, and this is a very minor fix, let us know if you have any concerns.

@feich-ms feich-ms merged commit da24593 into master Mar 9, 2020
@feich-ms feich-ms deleted the feich/lubuildFix branch March 9, 2020 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.