Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Vishwac/lu recursive resolve#615

Merged
vishwacsena merged 6 commits intomastermicrosoft/botframework-cli:masterfrom
vishwac/lu-recursive-resolvemicrosoft/botframework-cli:vishwac/lu-recursive-resolveCopy head branch name to clipboard
Feb 29, 2020
Merged

Vishwac/lu recursive resolve#615
vishwacsena merged 6 commits intomastermicrosoft/botframework-cli:masterfrom
vishwac/lu-recursive-resolvemicrosoft/botframework-cli:vishwac/lu-recursive-resolveCopy head branch name to clipboard

Conversation

@vishwacsena
Copy link
Contributor

Updated luMerger to supported nested import statements
Added new tests to verify recursive resolution

packages/lu/src/parser/lu/luMerger.js Show resolved Hide resolved
packages/lu/src/parser/lu/luMerger.js Show resolved Hide resolved
Copy link
Contributor

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIL

packages/lu/src/parser/lu/luMerger.js Outdated Show resolved Hide resolved
packages/lu/src/parser/lu/luMerger.js Show resolved Hide resolved
packages/lu/src/parser/lu/luMerger.js Show resolved Hide resolved
Copy link
Contributor

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIL 2

@vishwacsena vishwacsena merged commit a8d711b into master Feb 29, 2020
@vishwacsena vishwacsena deleted the vishwac/lu-recursive-resolve branch February 29, 2020 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.