This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Refactor lu api#597
Merged
vishwacsena merged 15 commits intomastermicrosoft/botframework-cli:masterfrom Feb 27, 2020
emimunoz/refactor-lu-apimicrosoft/botframework-cli:emimunoz/refactor-lu-apiCopy head branch name to clipboard
Merged
Refactor lu api#597vishwacsena merged 15 commits intomastermicrosoft/botframework-cli:masterfrom emimunoz/refactor-lu-apimicrosoft/botframework-cli:emimunoz/refactor-lu-apiCopy head branch name to clipboard
vishwacsena merged 15 commits intomastermicrosoft/botframework-cli:masterfrom
emimunoz/refactor-lu-apimicrosoft/botframework-cli:emimunoz/refactor-lu-apiCopy head branch name to clipboard
Conversation
This was referenced Feb 25, 2020
Contributor
Author
|
/azp run |
|
Pull request contains merge conflicts. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
feich-ms
reviewed
Feb 26, 2020
| Parser: require('./lufile/classes/parserObject') | ||
| }, | ||
| sectionHandler: { | ||
| luParser: require('./lufile/luParser'), |
Contributor
There was a problem hiding this comment.
Maybe sectionHandler can also be moved to composerindex.js. I will expose lubuild related modules in index.js after this PR is merged.
feich-ms
approved these changes
Feb 26, 2020
vishwacsena
reviewed
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.