This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Adding luis:application:create cmd and tests / refactor utils and clo…#351
Merged
munozemilio merged 4 commits intomastermicrosoft/botframework-cli:masterfrom Nov 13, 2019
302-luis-application-createmicrosoft/botframework-cli:302-luis-application-createCopy head branch name to clipboard
Merged
Adding luis:application:create cmd and tests / refactor utils and clo…#351munozemilio merged 4 commits intomastermicrosoft/botframework-cli:masterfrom 302-luis-application-createmicrosoft/botframework-cli:302-luis-application-createCopy head branch name to clipboard
munozemilio merged 4 commits intomastermicrosoft/botframework-cli:masterfrom
302-luis-application-createmicrosoft/botframework-cli:302-luis-application-createCopy head branch name to clipboard
Conversation
jspruance
commented
Nov 13, 2019
- create 'luis:application:create' cmd and tests
- refactor of utils to make input processing more generic
- update clone cmd to support utils refactor
munozemilio
reviewed
Nov 13, 2019
| const {flags} = this.parse(LuisApplicationCreate) | ||
| const flagLabels = Object.keys(LuisApplicationCreate.flags) | ||
| const configDir = this.config.configDir | ||
| const configPrefix = 'luis__' |
Contributor
There was a problem hiding this comment.
This should be moved to utils since it is the same for all commands
munozemilio
reviewed
Nov 13, 2019
| versionId: flags.versionId || (config ? config.luis__versionId : null), | ||
| targetVersionId: flags.targetVersionId || (config ? config.luis__targetVersionId : null) | ||
| } | ||
| const input: any = {} |
Contributor
There was a problem hiding this comment.
IMO the previous implementation is clearer to understand what the programs is retrieving from the config, plus it is easier to control the flow
Author
There was a problem hiding this comment.
But the previous implementation was hardcoded to one cmd (clone) so it wasn't flexible for general use. That's why I changed it to set the flags dynamically so that it works across the board.
munozemilio
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.