Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Close side panel

fix the bug that two strings can share the same hash code#1298

Merged
munozemilio merged 1 commit intomainmicrosoft/botframework-cli:mainfrom
hunyang/BF_LU_parser_luisCollate_BotframeworkBfLuLuisCollateMergeCanLeadToCollisionmicrosoft/botframework-cli:hunyang/BF_LU_parser_luisCollate_BotframeworkBfLuLuisCollateMergeCanLeadToCollisionCopy head branch name to clipboard
Sep 20, 2021
Merged

fix the bug that two strings can share the same hash code#1298
munozemilio merged 1 commit intomainmicrosoft/botframework-cli:mainfrom
hunyang/BF_LU_parser_luisCollate_BotframeworkBfLuLuisCollateMergeCanLeadToCollisionmicrosoft/botframework-cli:hunyang/BF_LU_parser_luisCollate_BotframeworkBfLuLuisCollateMergeCanLeadToCollisionCopy head branch name to clipboard

Conversation

@hcyang
Copy link
Contributor

@hcyang hcyang commented Sep 20, 2021

Fix #1297

@hcyang hcyang requested review from daveta and tsuwandy September 20, 2021 15:35
@hcyang hcyang requested a review from munozemilio as a code owner September 20, 2021 15:35
@munozemilio munozemilio merged commit fcb2cdb into main Sep 20, 2021
@munozemilio munozemilio deleted the hunyang/BF_LU_parser_luisCollate_BotframeworkBfLuLuisCollateMergeCanLeadToCollision branch September 20, 2021 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In luisCollate.js, the mergeResultsWithHash uses a hash code/table that can lead to collision

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.