This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Improve error reporting of dialog:merge#1290
Merged
munozemilio merged 1 commit intomainmicrosoft/botframework-cli:mainfrom Sep 14, 2021
Merged
Improve error reporting of dialog:merge#1290munozemilio merged 1 commit intomainmicrosoft/botframework-cli:mainfrom
munozemilio merged 1 commit intomainmicrosoft/botframework-cli:mainfrom
Conversation
joshgummersall
approved these changes
Sep 13, 2021
munozemilio
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1289
The fix was to make the error reporting better.
In this case a proxy error would return a string
which we would then treat as an object.
Also cleaned up a few lint issues.