This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Add range in diagnostic of reserved prebuilt entity name#1260
Merged
munozemilio merged 2 commits intomainmicrosoft/botframework-cli:mainfrom Jul 2, 2021
shuwan/addErrorRangemicrosoft/botframework-cli:shuwan/addErrorRangeCopy head branch name to clipboard
Merged
Add range in diagnostic of reserved prebuilt entity name#1260munozemilio merged 2 commits intomainmicrosoft/botframework-cli:mainfrom shuwan/addErrorRangemicrosoft/botframework-cli:shuwan/addErrorRangeCopy head branch name to clipboard
munozemilio merged 2 commits intomainmicrosoft/botframework-cli:mainfrom
shuwan/addErrorRangemicrosoft/botframework-cli:shuwan/addErrorRangeCopy head branch name to clipboard
Conversation
munozemilio
approved these changes
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1250
The error of using a reserved entity name should throws error with range infomation. So that the Lu editor in Composer could display correct error range.