This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Support passing in information about external functions in lg:analyze#1237
Merged
munozemilio merged 7 commits intomainmicrosoft/botframework-cli:mainfrom Jun 24, 2021
shuwan/allowExternalFuncInLgmicrosoft/botframework-cli:shuwan/allowExternalFuncInLgCopy head branch name to clipboard
Merged
Support passing in information about external functions in lg:analyze#1237munozemilio merged 7 commits intomainmicrosoft/botframework-cli:mainfrom shuwan/allowExternalFuncInLgmicrosoft/botframework-cli:shuwan/allowExternalFuncInLgCopy head branch name to clipboard
munozemilio merged 7 commits intomainmicrosoft/botframework-cli:mainfrom
shuwan/allowExternalFuncInLgmicrosoft/botframework-cli:shuwan/allowExternalFuncInLgCopy head branch name to clipboard
Conversation
|
|
||
| Helper.checkInputAndOutput(lgFilePaths) | ||
| if (flags['external-functions']) { | ||
| const functionList = flags['external-functions'].split(',') |
Contributor
There was a problem hiding this comment.
Does this work for "function1,function2" as well as "function1 , function2"?
Contributor
Author
There was a problem hiding this comment.
I don't think so, "function1 , function2", the cli will take ", function2" as another argument
Contributor
|
@scheyal could you please approve from PM side? |
joshgummersall
approved these changes
Jun 10, 2021
munozemilio
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1220
With --external-functions flag, user can pass in external functions to lg:analyze command. This will help users avoid
has no evaluatorerror