This repository was archived by the owner on Jan 15, 2025. It is now read-only.
fix import filtered intents not work in luis:cross-train#1232
Merged
munozemilio merged 14 commits intomainmicrosoft/botframework-cli:mainfrom Jun 3, 2021
shuwan/fixFilterIntentmicrosoft/botframework-cli:shuwan/fixFilterIntentCopy head branch name to clipboard
Merged
fix import filtered intents not work in luis:cross-train#1232munozemilio merged 14 commits intomainmicrosoft/botframework-cli:mainfrom shuwan/fixFilterIntentmicrosoft/botframework-cli:shuwan/fixFilterIntentCopy head branch name to clipboard
munozemilio merged 14 commits intomainmicrosoft/botframework-cli:mainfrom
shuwan/fixFilterIntentmicrosoft/botframework-cli:shuwan/fixFilterIntentCopy head branch name to clipboard
Conversation
munozemilio
reviewed
May 17, 2021
munozemilio
suggested changes
May 17, 2021
Contributor
munozemilio
left a comment
There was a problem hiding this comment.
Small comment on code optimization
munozemilio
reviewed
May 25, 2021
munozemilio
reviewed
May 25, 2021
munozemilio
reviewed
May 25, 2021
|
|
||
| const matchedUtterence = luObj.utterances.find(e => e.intent === intent) | ||
| const fileContent = `# ${intent}\r\n${parseUtterancesToLu([matchedUtterence], luObj)}` | ||
| let cloned = {...(isAbsolutePath ? importFile : filePathOrFound[0])} |
Contributor
There was a problem hiding this comment.
const, also does this need to be a deep clone?
Contributor
Author
There was a problem hiding this comment.
The reason I used a deep clone here is due to I don't want to change the original content of luis and qna files.
Contributor
There was a problem hiding this comment.
This isn't a deep clone actually, that was my question. See Typescript playground for explanataion.
Contributor
Author
There was a problem hiding this comment.
I see. I just fixed this.
joshgummersall
approved these changes
Jun 1, 2021
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Jun 21, 2023
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1210
In this PR, for the test cases of using imported intents User report case will only includes the referenced intents in the generated files.
Here is the new result of Cross-train for that case above: