This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Fix intent import in lu merger will pull unrelated contents in some corner cases#1124
Merged
munozemilio merged 1 commit intomainmicrosoft/botframework-cli:mainfrom Feb 19, 2021
feich/fixImportIssuemicrosoft/botframework-cli:feich/fixImportIssueCopy head branch name to clipboard
Merged
Fix intent import in lu merger will pull unrelated contents in some corner cases#1124munozemilio merged 1 commit intomainmicrosoft/botframework-cli:mainfrom feich/fixImportIssuemicrosoft/botframework-cli:feich/fixImportIssueCopy head branch name to clipboard
munozemilio merged 1 commit intomainmicrosoft/botframework-cli:mainfrom
feich/fixImportIssuemicrosoft/botframework-cli:feich/fixImportIssueCopy head branch name to clipboard
Conversation
Contributor
Author
|
Hi @munozemilio, this bug was just reported by composer users recently. In some corner situations, intent import will pull some unrelated contents into current luis file due to some bug in our lu merger. I made a fix here. If there is another rc1 release for bf-cli, I think it would be helpful to cherry-pick this in. Thanks. |
munozemilio
approved these changes
Feb 19, 2021
munozemilio
pushed a commit
that referenced
this pull request
Feb 20, 2021
munozemilio
added a commit
that referenced
this pull request
Feb 20, 2021
* fix import bug (#1124) * Add support for verifying $policies. (#1126) * Add support for verifying $policies. * Remove unneed package reference. Co-authored-by: Chris McConnell <chrimc> Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: Chris McConnell <chrimc@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1123 to resolve the issue that intent import in lu will pull unrelated contents in some corner cases.