This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Adding mode flag to train command#1113
Merged
munozemilio merged 3 commits intomainmicrosoft/botframework-cli:mainfrom Feb 10, 2021
emimunoz/luis-train-modemicrosoft/botframework-cli:emimunoz/luis-train-modeCopy head branch name to clipboard
Merged
Adding mode flag to train command#1113munozemilio merged 3 commits intomainmicrosoft/botframework-cli:mainfrom emimunoz/luis-train-modemicrosoft/botframework-cli:emimunoz/luis-train-modeCopy head branch name to clipboard
munozemilio merged 3 commits intomainmicrosoft/botframework-cli:mainfrom
emimunoz/luis-train-modemicrosoft/botframework-cli:emimunoz/luis-train-modeCopy head branch name to clipboard
Conversation
joshgummersall
approved these changes
Feb 10, 2021
Contributor
joshgummersall
left a comment
There was a problem hiding this comment.
One suggestion, one question. LGTM though.
|
|
||
| try { | ||
| const trainingRequestStatus = await Train.train({subscriptionKey, endpoint, appId}, versionId) | ||
| const trainingRequestStatus = await Train.train({subscriptionKey, endpoint, appId}, versionId, flags.mode) |
Contributor
There was a problem hiding this comment.
Are string flags defaulted to ''?
Contributor
There was a problem hiding this comment.
It's pedantic, but if undefined is a valid type for the mode parameter, the train function signature should be (..., mode?: string). strict mode would raise an error here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1087