This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Fix luis converter to enable escaping specific chars#1111
Merged
feich-ms merged 3 commits intomainmicrosoft/botframework-cli:mainfrom Feb 9, 2021
feich/FixLUISConvertermicrosoft/botframework-cli:feich/FixLUISConverterCopy head branch name to clipboard
Merged
Fix luis converter to enable escaping specific chars#1111feich-ms merged 3 commits intomainmicrosoft/botframework-cli:mainfrom feich/FixLUISConvertermicrosoft/botframework-cli:feich/FixLUISConverterCopy head branch name to clipboard
feich-ms merged 3 commits intomainmicrosoft/botframework-cli:mainfrom
feich/FixLUISConvertermicrosoft/botframework-cli:feich/FixLUISConverterCopy head branch name to clipboard
Conversation
Contributor
Author
|
Hi @munozemilio, could you please help to check if this fix will introduce any potential issues since it's touching luis converter logic that you have more experiences. |
munozemilio
approved these changes
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1110. With the fix, luis converter can add necessary escape characters when converting luis json file to lu file. With these escape characters added, the lu content can be converted back to luis json file successfully without any exceptions. That means such escaping corner cases between lu and luis converting will be handled well with this fix. Test cases from customers were added to verify the fix.
Previous fix #1104 and #1106 that didn't resolve the issue completely