This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Fix the issue caused by additional semicolon at the end of some lu definitions#1093
Merged
feich-ms merged 8 commits intomainmicrosoft/botframework-cli:mainfrom Jan 27, 2021
feich/OptimizeSyntaxValidationmicrosoft/botframework-cli:feich/OptimizeSyntaxValidationCopy head branch name to clipboard
Merged
Fix the issue caused by additional semicolon at the end of some lu definitions#1093feich-ms merged 8 commits intomainmicrosoft/botframework-cli:mainfrom feich/OptimizeSyntaxValidationmicrosoft/botframework-cli:feich/OptimizeSyntaxValidationCopy head branch name to clipboard
feich-ms merged 8 commits intomainmicrosoft/botframework-cli:mainfrom
feich/OptimizeSyntaxValidationmicrosoft/botframework-cli:feich/OptimizeSyntaxValidationCopy head branch name to clipboard
Conversation
boydc2014
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the third issue reported in #1092.
Before the fix, semicolon at the end of List entity/Composite entity/phraseList/useFeatures of nDepth definitions will cause string splitting function to add an additional empty string into array which will cause exceptions in the following parsing. After the fix, all the empty string will be removed from the array and the following functions can work correctly.
Test cases are added to validate these fixes.