Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Close side panel

Lowercase package names#1073

Merged
chrimc62 merged 2 commits intomainmicrosoft/botframework-cli:mainfrom
chrimc/casemicrosoft/botframework-cli:chrimc/caseCopy head branch name to clipboard
Dec 10, 2020
Merged

Lowercase package names#1073
chrimc62 merged 2 commits intomainmicrosoft/botframework-cli:mainfrom
chrimc/casemicrosoft/botframework-cli:chrimc/caseCopy head branch name to clipboard

Conversation

@chrimc62
Copy link

@chrimc62 chrimc62 commented Dec 9, 2020

Mac/linux dotnet lowercases all package names which prevents dialog:merge from working since the package names are often mixed case and file matching is case sensitive.

Mac/linux dotnet lowercases all package names.
@chrimc62 chrimc62 marked this pull request as ready for review December 9, 2020 23:22
packages/dialog/src/library/schemaMerger.ts Outdated Show resolved Hide resolved
@chrimc62 chrimc62 merged commit e06f70f into main Dec 10, 2020
@munozemilio munozemilio deleted the chrimc/case branch February 12, 2021 21:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.