This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Support special chars in intent name when parsing lu with antlr#1058
Merged
munozemilio merged 2 commits intomainmicrosoft/botframework-cli:mainfrom Nov 25, 2020
feich/SupportSpecialCharInIntentNamemicrosoft/botframework-cli:feich/SupportSpecialCharInIntentNameCopy head branch name to clipboard
Merged
Support special chars in intent name when parsing lu with antlr#1058munozemilio merged 2 commits intomainmicrosoft/botframework-cli:mainfrom feich/SupportSpecialCharInIntentNamemicrosoft/botframework-cli:feich/SupportSpecialCharInIntentNameCopy head branch name to clipboard
munozemilio merged 2 commits intomainmicrosoft/botframework-cli:mainfrom
feich/SupportSpecialCharInIntentNamemicrosoft/botframework-cli:feich/SupportSpecialCharInIntentNameCopy head branch name to clipboard
Conversation
Contributor
Author
|
@munozemilio could you take a review? |
munozemilio
approved these changes
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1052 to support special chars in intent name when parsing lu file with antlr.
Tests are added for both lu parser and luis convert cmd.