This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Replacing node-fetch with axios to get proxy detection#1036
Merged
munozemilio merged 3 commits intomainmicrosoft/botframework-cli:mainfrom Oct 26, 2020
emimunoz/axios-proxymicrosoft/botframework-cli:emimunoz/axios-proxyCopy head branch name to clipboard
Merged
Replacing node-fetch with axios to get proxy detection#1036munozemilio merged 3 commits intomainmicrosoft/botframework-cli:mainfrom emimunoz/axios-proxymicrosoft/botframework-cli:emimunoz/axios-proxyCopy head branch name to clipboard
munozemilio merged 3 commits intomainmicrosoft/botframework-cli:mainfrom
emimunoz/axios-proxymicrosoft/botframework-cli:emimunoz/axios-proxyCopy head branch name to clipboard
Conversation
feich-ms
reviewed
Oct 26, 2020
feich-ms
approved these changes
Oct 26, 2020
Contributor
feich-ms
left a comment
There was a problem hiding this comment.
One minor comment. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #968