This repository was archived by the owner on Jan 15, 2025. It is now read-only.
remove unused dup hash in luis/qnamaker build when reconstructing files#1026
Merged
feich-ms merged 5 commits intomainmicrosoft/botframework-cli:mainfrom Oct 23, 2020
feich/removeUnusedHashmicrosoft/botframework-cli:feich/removeUnusedHashCopy head branch name to clipboard
Merged
remove unused dup hash in luis/qnamaker build when reconstructing files#1026feich-ms merged 5 commits intomainmicrosoft/botframework-cli:mainfrom feich/removeUnusedHashmicrosoft/botframework-cli:feich/removeUnusedHashCopy head branch name to clipboard
feich-ms merged 5 commits intomainmicrosoft/botframework-cli:mainfrom
feich/removeUnusedHashmicrosoft/botframework-cli:feich/removeUnusedHashCopy head branch name to clipboard
Conversation
boydc2014
approved these changes
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before changes, when calling luConverter or qnaConverter, it will add double hash before intent name for luis and double hash before first question for qnamaker which is confusing users since we are always using single hash now. After changes, it will only keep one hash when reconstructing the lu or qna files. Of course, double hash is still working for parsing. The changes here only apply for reconstructing lu or qna files from json object.