Adding headers to test common header files #5903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several test header files to improve consistency and ensure all necessary dependencies are explicitly included. The main focus is on adding missing system and library includes, which helps prevent build issues and makes dependencies clearer for future maintenance.
Dependency inclusion improvements:
<windows.h>,<winrt/base.h>,<WexTestClass.h>,<appmodel.h>,<Verify.h>, and<filesystem>to multiple test headers includingTestDef.h,WindowsAppRuntime.Test.AppModel.h,WindowsAppRuntime.Test.Bootstrap.h,WindowsAppRuntime.Test.FileSystem.h,WindowsAppRuntime.Test.Package.h,WindowsAppRuntime.Test.TAEF.cppwinrt.h, andWindowsAppRuntime.Test.TAEF.h. [1] [2] [3] [4] [5] [6] [7]These changes help ensuring that each header is independent and handle its own dependencies. Without these explicit dependencies, when creating a new test file, we need to know precisely the order in which to include each header for them to work, as some headers are dependent on external includes to exist. Or use one of the
.pchfiles as example, but then making it harder to maintain as the dependencies are hidden and we end up including unnecessary files.This is also stated on C++ Core Guidelines.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.