Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Better Memory Tracking + Follow Transform Override + UX Improvements#40

Merged
Cameron-Micka merged 15 commits intomicrosoft:mainmicrosoft/VisualProfiler-Unity:mainfrom
Cameron-Micka:user/cameron-micka/better-memory-trackingCameron-Micka/VisualProfiler-Unity:user/cameron-micka/better-memory-trackingCopy head branch name to clipboard
Aug 19, 2024
Merged

Better Memory Tracking + Follow Transform Override + UX Improvements#40
Cameron-Micka merged 15 commits intomicrosoft:mainmicrosoft/VisualProfiler-Unity:mainfrom
Cameron-Micka:user/cameron-micka/better-memory-trackingCameron-Micka/VisualProfiler-Unity:user/cameron-micka/better-memory-trackingCopy head branch name to clipboard

Conversation

@Cameron-Micka
Copy link
Member

Overview

This PR introduces a few changes:

  1. Memory usage now displays "System Used Memory" which will return the "working set" of the process which is similar to what Task Manager displays in Windows. But this is not available on all platforms (like WebGL) so instead return Profiler.GetTotalReservedMemoryLong() which is the total memory Unity has reserved for current and future allocations.

  2. A New property called "TransformToFollow" has been added to allow users to select a transform to follow rather than the main camera. The sample scene has been updated to show off this behavior:
    image

  3. Finally, some minor UX changes to hide cpu/gpu timing when it's not available and the ability to tune what is considered a missed frame or not.

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@Cameron-Micka Cameron-Micka merged commit 580a58f into microsoft:main Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Positioning is difficult. Please improve.

1 participant

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.