Conform doc comments to TSDoc spec (experiment)#50736
Closed
jakebailey wants to merge 2 commits intomicrosoft:mainmicrosoft/TypeScript:mainfrom
Closed
Conform doc comments to TSDoc spec (experiment)#50736jakebailey wants to merge 2 commits intomicrosoft:mainmicrosoft/TypeScript:mainfrom
jakebailey wants to merge 2 commits intomicrosoft:mainmicrosoft/TypeScript:mainfrom
Conversation
Collaborator
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
Member
Author
|
Thanks bot for pinging everyone... 😠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just an experiment to see what it'd be like to conform to the TSDoc spec. The main change is the requirement of a dash after the parameter name, which the plugin complains about (however, their parser is lenient and doesn't need it; I wish the lint didn't complain, see microsoft/tsdoc#220).
Their ESLint plugin is thankfully not too slow to add:
The generated TS lib files would also need to be updated, but we don't lint those as they come from the DOM generator.