microsoft
diff --git a/‎src/services/completions.ts
Copy file name to clipboardExpand all lines: src/services/completions.ts
+2-6Lines changed: 2 additions & 6 deletions b/‎src/services/completions.ts
Copy file name to clipboardExpand all lines: src/services/completions.ts
+2-6Lines changed: 2 additions & 6 deletions
diff --git a/‎src/services/stringCompletions.ts
Copy file name to clipboardExpand all lines: src/services/stringCompletions.ts
+8-4Lines changed: 8 additions & 4 deletions b/‎src/services/stringCompletions.ts
Copy file name to clipboardExpand all lines: src/services/stringCompletions.ts
+8-4Lines changed: 8 additions & 4 deletions
diff --git a/‎tests/cases/fourslash/getJavaScriptCompletions21.ts
Copy file name to clipboard
+15Lines changed: 15 additions & 0 deletions b/‎tests/cases/fourslash/getJavaScriptCompletions21.ts
Copy file name to clipboard
+15Lines changed: 15 additions & 0 deletions
@@ -403,8 +403,8 @@ namespace ts.Completions {
             kindModifiers: SymbolDisplay.getSymbolModifiers(symbol),
             sortText,
             source: getSourceFromOrigin(origin),
-            hasAction: trueOrUndefined(!!origin && originIsExport(origin)),
-            isRecommended: trueOrUndefined(isRecommendedCompletionMatch(symbol, recommendedCompletion, typeChecker)),
+            hasAction: origin && originIsExport(origin) || undefined,
+            isRecommended: isRecommendedCompletionMatch(symbol, recommendedCompletion, typeChecker) || undefined,
             insertText,
             replacementSpan,
         };
@@ -415,10 +415,6 @@ namespace ts.Completions {
             !!(localSymbol.flags & SymbolFlags.ExportValue) && checker.getExportSymbolOfSymbol(localSymbol) === recommendedCompletion;
     }
 
-    function trueOrUndefined(b: boolean): true | undefined {
-        return b ? true : undefined;
-    }
-
     function getSourceFromOrigin(origin: SymbolOriginInfo | undefined): string | undefined {
         return origin && originIsExport(origin) ? stripQuotes(origin.moduleSymbol.name) : undefined;
     }
 
@@ -6,9 +6,9 @@ namespace ts.Completions.StringCompletions {
             return entries && convertPathCompletions(entries);
         }
         if (isInString(sourceFile, position, contextToken)) {
-            return !contextToken || !isStringLiteralLike(contextToken)
-                ? undefined
-                : convertStringLiteralCompletions(getStringLiteralCompletionEntries(sourceFile, contextToken, position, checker, options, host), sourceFile, checker, log, preferences);
+            if (!contextToken || !isStringLiteralLike(contextToken)) return undefined;
+            const entries = getStringLiteralCompletionEntries(sourceFile, contextToken, position, checker, options, host);
+            return convertStringLiteralCompletions(entries, sourceFile, checker, log, preferences);
         }
     }
 
@@ -214,7 +214,11 @@ namespace ts.Completions.StringCompletions {
     }
 
     function stringLiteralCompletionsFromProperties(type: Type | undefined): StringLiteralCompletionsFromProperties | undefined {
-        return type && { kind: StringLiteralCompletionKind.Properties, symbols: type.getApparentProperties(), hasIndexSignature: hasIndexSignature(type) };
+        return type && {
+            kind: StringLiteralCompletionKind.Properties,
+            symbols: type.getApparentProperties().filter(prop => !isPrivateIdentifierPropertyDeclaration(prop.valueDeclaration)),
+            hasIndexSignature: hasIndexSignature(type)
+        };
     }
 
     function getStringLiteralTypes(type: Type | undefined, uniques = createMap<true>()): readonly StringLiteralType[] {
 
@@ -0,0 +1,15 @@
+/// <reference path="fourslash.ts" />
+
+// @allowNonTsExtensions: true
+// @Filename: file.js
+
+////class Prv {
+////    #privatething = 1;
+////    notSoPrivate = 1;
+////}
+////new Prv()['/**/'];
+
+verify.completions({
+    marker: "",
+    exact: ["notSoPrivate"]
+});
Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,9 @@ namespace ts.Completions.StringCompletions {`
`6`	`6`	`return entries && convertPathCompletions(entries);`
`7`	`7`	`}`
`8`	`8`	`if (isInString(sourceFile, position, contextToken)) {`
`9`		`- return !contextToken \|\| !isStringLiteralLike(contextToken)`
`10`		`- ? undefined`
`11`		`- : convertStringLiteralCompletions(getStringLiteralCompletionEntries(sourceFile, contextToken, position, checker, options, host), sourceFile, checker, log, preferences);`
	`9`	`+ if (!contextToken \|\| !isStringLiteralLike(contextToken)) return undefined;`
	`10`	`+ const entries = getStringLiteralCompletionEntries(sourceFile, contextToken, position, checker, options, host);`
	`11`	`+ return convertStringLiteralCompletions(entries, sourceFile, checker, log, preferences);`
`12`	`12`	`}`
`13`	`13`	`}`
`14`	`14`
`@@ -214,7 +214,11 @@ namespace ts.Completions.StringCompletions {`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`function stringLiteralCompletionsFromProperties(type: Type \| undefined): StringLiteralCompletionsFromProperties \| undefined {`
`217`		`- return type && { kind: StringLiteralCompletionKind.Properties, symbols: type.getApparentProperties(), hasIndexSignature: hasIndexSignature(type) };`
	`217`	`+ return type && {`
	`218`	`+ kind: StringLiteralCompletionKind.Properties,`
	`219`	`+ symbols: type.getApparentProperties().filter(prop => !isPrivateIdentifierPropertyDeclaration(prop.valueDeclaration)),`
	`220`	`+ hasIndexSignature: hasIndexSignature(type)`
	`221`	`+ };`
`218`	`222`	`}`
`219`	`223`
`220`	`224`	`function getStringLiteralTypes(type: Type \| undefined, uniques = createMap<true>()): readonly StringLiteralType[] {`