Add Neon implementation of minmax #5963
Draft
+841
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the namespace _Sorting algorithms using Neon, and enable _VECTORIZED_MINMAX on ARM64 targets.
Add and enable a Neon implementation of minmax on ARM64 platforms. The existing code is refactored to support an unrolled version for sufficiently large inputs.
3119a3a to
c92dcef
Compare
| _INLINE_VAR constexpr bool _Is_64bit_int_on_arm64_v = false; | ||
| #endif // ^^^ defined(_M_ARM64) ^^^ | ||
|
|
||
| template <class _Iter, class _Pr, bool _Support64BitIntOnArm = false> |
Contributor
There was a problem hiding this comment.
I'd prefer that we expose this quirk less. Instead of adding template parameter, you could do one of this:
- Just repeat the
_Is_min_max_iterators_safe<_Iter> && _Is_predicate_less<_Iter, _Pr>formula in_Is_min_max_value_optimization_safe - Extract common base for
_Is_min_max_optimization_safeand_Is_min_max_value_optimization_safe
| return vreinterpretq_s64_u64(vcgtq_u64(vreinterpretq_u64_s64(_First), vreinterpretq_u64_s64(_Second))); | ||
| } | ||
|
|
||
| static _Vec_t _Min(const _Vec_t _First, const _Vec_t _Second, _Vec_t _Mask) noexcept { |
Contributor
There was a problem hiding this comment.
const _Mask .
I observe it is interesting that both ISA have same limitation of having usual vector max for 32-bit elements, but having to blend for 64bit elements.
| return _Min(_First, _Second, _Cmp_gt_u(_First, _Second)); | ||
| } | ||
|
|
||
| static _Vec_t _Max(const _Vec_t _First, const _Vec_t _Second, _Vec_t _Mask) noexcept { |
| _Advance_bytes(_First, sizeof(_Ty)); | ||
| } | ||
|
|
||
| #pragma loop(no_vector) |
Contributor
There was a problem hiding this comment.
Is this a bug fix, or just a performance thing?
In either cases may worth commenting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stacked on #5949.
Performance numbers: