Replaces instances of anyOf to oneOf#264
Merged
irvinesunday merged 27 commits intomastermicrosoft/OpenAPI.NET.OData:masterfrom Sep 8, 2022
fix/is/anyOf-oneOf-inversionmicrosoft/OpenAPI.NET.OData:fix/is/anyOf-oneOf-inversionCopy head branch name to clipboard
Merged
Replaces instances of anyOf to oneOf#264irvinesunday merged 27 commits intomastermicrosoft/OpenAPI.NET.OData:masterfrom fix/is/anyOf-oneOf-inversionmicrosoft/OpenAPI.NET.OData:fix/is/anyOf-oneOf-inversionCopy head branch name to clipboard
anyOf to oneOf#264irvinesunday merged 27 commits intomastermicrosoft/OpenAPI.NET.OData:masterfrom
fix/is/anyOf-oneOf-inversionmicrosoft/OpenAPI.NET.OData:fix/is/anyOf-oneOf-inversionCopy head branch name to clipboard
Conversation
baywet
requested changes
Aug 18, 2022
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for addressing this, a couple of remarks
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
baywet
requested changes
Aug 24, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
…rator.cs Co-authored-by: Vincent Biret <vibiret@microsoft.com>
baywet
requested changes
Aug 24, 2022
Member
baywet
left a comment
There was a problem hiding this comment.
sorry I missed the affectation
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
baywet
requested changes
Aug 25, 2022
test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/TripService.OpenApi.V2.json
Outdated
Show resolved
Hide resolved
baywet
requested changes
Sep 2, 2022
test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/TripService.OpenApi.V2.json
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiEdmTypeSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
Member
|
I think some unit tests still need to be updated and we should be good to go after that. |
This is because `Explode = false` for the OData query parameters.
baywet
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245
This PR:
anyOftooneOffor geometric points.anyOftooneOfforDecimal,Double,SingleandInt64EdmPrimitiveTypeKind.