Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Parse Nested postman collections#794

Merged
darrelmiller merged 11 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
enhancement/nested-postman-collectionmicrosoft/OpenAPI.NET:enhancement/nested-postman-collectionCopy head branch name to clipboard
Mar 27, 2022
Merged

Parse Nested postman collections#794
darrelmiller merged 11 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
enhancement/nested-postman-collectionmicrosoft/OpenAPI.NET:enhancement/nested-postman-collectionCopy head branch name to clipboard

Conversation

@MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Mar 15, 2022

Fixes #777,
Fixes #787

This PR:

  • Refactors the ParseJsonCollectionFile logic to use a recursive solution that helps parse single-level or multi-level deeply nested item arrays containing the request object from which we extract the request URLs.
  • Adds unit tests for both single-level nested item arrays and double-level nested arrays for validation
  • Logs a warning message to the console when a URL in the postman collection isn't present in the input OpenApi document instead of terminating the entire process
  • Updates the conditional operator to infer OpenApiSpecVersion from the diagnostics object if a user doesn't supply the version parameter

@MaggieKimani1 MaggieKimani1 changed the title Parse Nested postman collection Parse Nested postman collections Mar 15, 2022
@darrelmiller darrelmiller merged commit 976b5cc into vnext Mar 27, 2022
@darrelmiller darrelmiller deleted the enhancement/nested-postman-collection branch March 27, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.