Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Better error handling#785

Merged
MaggieKimani1 merged 7 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
fix/better-error-displaymicrosoft/OpenAPI.NET:fix/better-error-displayCopy head branch name to clipboard
Mar 8, 2022
Merged

Better error handling#785
MaggieKimani1 merged 7 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
fix/better-error-displaymicrosoft/OpenAPI.NET:fix/better-error-displayCopy head branch name to clipboard

Conversation

@MaggieKimani1
Copy link
Contributor

Fixes #784

  • Passes the cancellation token from the system.command line host to async APIs to avoid getting task cancelled exceptions when users press ctrl + c
  • Formats the logging to use templates instead of doing string interpolation so logging APIs can do sampling and metrics

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for starting the work here, a couple of comments.

src/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi.Hidi/OpenApiService.cs Show resolved Hide resolved
@baywet baywet force-pushed the fix/better-error-display branch from 48b1294 to 9544806 Compare March 8, 2022 19:37
@MaggieKimani1 MaggieKimani1 merged commit 0d9d96b into vnext Mar 8, 2022
@MaggieKimani1 MaggieKimani1 deleted the fix/better-error-display branch March 8, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better Exception handling in Hidi

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.