Simplify openapi spec version for Hidi#767
Merged
darrelmiller merged 5 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom Mar 9, 2022
fix/simplify-openapi-spec-versionmicrosoft/OpenAPI.NET:fix/simplify-openapi-spec-versionCopy head branch name to clipboard
Merged
Simplify openapi spec version for Hidi#767darrelmiller merged 5 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom fix/simplify-openapi-spec-versionmicrosoft/OpenAPI.NET:fix/simplify-openapi-spec-versionCopy head branch name to clipboard
darrelmiller merged 5 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
fix/simplify-openapi-spec-versionmicrosoft/OpenAPI.NET:fix/simplify-openapi-spec-versionCopy head branch name to clipboard
Conversation
darrelmiller
reviewed
Mar 6, 2022
| { | ||
| public static class OpenApiSpecVersionExtension | ||
| { | ||
| public static OpenApiSpecVersion TryParseOpenApiSpecVersion(this string value) |
Member
There was a problem hiding this comment.
Extension methods on very commonly used types like string are not usually recommended. If every use of a string did this it would hugely increase the surface are of the String class. I would suggest just renaming this to OpenApiSpecVersionHelper and accept the string as a regular parameter.
Contributor
Author
There was a problem hiding this comment.
Thank you for pointing this out. Resolving...
darrelmiller
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #732