Open api example comparer#331
Merged
Shwetap05 merged 6 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom Oct 16, 2018
OpenApiExampleComparermicrosoft/OpenAPI.NET:OpenApiExampleComparerCopy head branch name to clipboard
Merged
Open api example comparer#331Shwetap05 merged 6 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom OpenApiExampleComparermicrosoft/OpenAPI.NET:OpenApiExampleComparerCopy head branch name to clipboard
Shwetap05 merged 6 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
OpenApiExampleComparermicrosoft/OpenAPI.NET:OpenApiExampleComparerCopy head branch name to clipboard
Conversation
- OpenApiInfo - OpenApiContact - OpenApiLicense - OpenApiExternalDocs - OpenApiSecurityRequirements - OpenApiTag
| return; | ||
| } | ||
|
|
||
| if (string.Compare(sourceValue, targetValue, StringComparison.CurrentCultureIgnoreCase) != 0) |
Contributor
There was a problem hiding this comment.
CurrentCultureIgnoreCase [](start = 74, length = 24)
InvariantCulture
We should not ignore case here. #Resolved
| if (string.IsNullOrWhiteSpace(sourceValue) && string.IsNullOrWhiteSpace(targetValue)) | ||
| { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need this special handling? #Resolved
Member
Author
There was a problem hiding this comment.
| .GetComparer<IDictionary<string, OpenApiServerVariable>>() | ||
| .Compare(sourceServer.Variables, sourceServer.Variables, comparisonContext)); | ||
|
|
||
| // To Do compare extensions |
Contributor
There was a problem hiding this comment.
Why are we removing these "// To Do compare extensions" comments? #Resolved
Member
Author
There was a problem hiding this comment.
i will be tracking this work as an issue on github instead of adding these ToDo
In reply to: 225337695 [](ancestors = 225337695)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open api example comparer