chore: implement test cases for types of References in an OpenApi document#2352
Merged
MaggieKimani1 merged 13 commits intomainmicrosoft/OpenAPI.NET:mainfrom Jun 2, 2025
feat-handle-relative-referencesmicrosoft/OpenAPI.NET:feat-handle-relative-referencesCopy head branch name to clipboard
Merged
chore: implement test cases for types of References in an OpenApi document#2352MaggieKimani1 merged 13 commits intomainmicrosoft/OpenAPI.NET:mainfrom feat-handle-relative-referencesmicrosoft/OpenAPI.NET:feat-handle-relative-referencesCopy head branch name to clipboard
MaggieKimani1 merged 13 commits intomainmicrosoft/OpenAPI.NET:mainfrom
feat-handle-relative-referencesmicrosoft/OpenAPI.NET:feat-handle-relative-referencesCopy head branch name to clipboard
Conversation
baywet
reviewed
May 16, 2025
Member
baywet
left a comment
There was a problem hiding this comment.
Here are a couple of comments to help move things along.
What I've done:
- high level review of the code.
- review of the samples that are present.
(before reading the spec to come with the freshest eyes possible into that)
What I have not done:
- check against the spec for missing samples.
- deep review of the code.
.../Microsoft.OpenApi.Readers.Tests/V31Tests/ReferenceSamples/rootComponentSchemaReference.yaml
Outdated
Show resolved
Hide resolved
...soft.OpenApi.Readers.Tests/V31Tests/ReferenceSamples/localReferenceToJsonSchemaResource.yaml
Show resolved
Hide resolved
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
baywet
reviewed
May 21, 2025
.../Microsoft.OpenApi.Readers.Tests/V31Tests/ReferenceSamples/rootComponentSchemaReference.yaml
Outdated
Show resolved
Hide resolved
|
baywet
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2062