Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix: support non-standard MIME type in response header#2124

Merged
baywet merged 4 commits intodevmicrosoft/OpenAPI.NET:devfrom
fix/loading-exceptionmicrosoft/OpenAPI.NET:fix/loading-exceptionCopy head branch name to clipboard
Feb 5, 2025
Merged

fix: support non-standard MIME type in response header#2124
baywet merged 4 commits intodevmicrosoft/OpenAPI.NET:devfrom
fix/loading-exceptionmicrosoft/OpenAPI.NET:fix/loading-exceptionCopy head branch name to clipboard

Conversation

@MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Feb 5, 2025

Fixes #1989 where the document's format was not being correctly set for non-standard MIME types when inspecting the content type header in a HTTP response object.
E.g. the MIME type text/x-yaml which is still in use by older libraries or APIs

@MaggieKimani1 MaggieKimani1 changed the title Fix: Support non-standard MIME type during format inference fix: support non-standard MIME type in response header Feb 5, 2025
@MaggieKimani1 MaggieKimani1 mentioned this pull request Feb 5, 2025
src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs Outdated Show resolved Hide resolved
@baywet baywet enabled auto-merge February 5, 2025 12:51
@baywet baywet merged commit 50ddca2 into dev Feb 5, 2025
9 of 12 checks passed
@baywet baywet deleted the fix/loading-exception branch February 5, 2025 12:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
58.3% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting NullReferenceException when deserializing a yaml document

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.