Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Add ValidationRuleSet.Remove#1535

Merged
baywet merged 56 commits intomicrosoft:vnextmicrosoft/OpenAPI.NET:vnextfrom
LucGenetier:masterLucGenetier/OpenAPI.NET:masterCopy head branch name to clipboard
Jan 24, 2024
Merged

Add ValidationRuleSet.Remove#1535
baywet merged 56 commits intomicrosoft:vnextmicrosoft/OpenAPI.NET:vnextfrom
LucGenetier:masterLucGenetier/OpenAPI.NET:masterCopy head branch name to clipboard

Conversation

@LucGenetier
Copy link
Contributor

No description provided.

baywet and others added 30 commits May 11, 2022 08:00
master refresh for hidi release
@baywet baywet changed the base branch from master to vnext January 22, 2024 15:11
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Here are a few comments

src/Microsoft.OpenApi/Validations/ValidationRule.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi/Validations/ValidationRule.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs Outdated Show resolved Hide resolved
@baywet
Copy link
Member

baywet commented Jan 22, 2024

Can you also rebase onto vnext please so we don't get all this merge commits in the way?

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, a couple more recommendations

src/Microsoft.OpenApi/Validations/ValidationRule.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi/Validations/ValidationRule.cs Outdated Show resolved Hide resolved
@LucGenetier
Copy link
Contributor Author

ok


In reply to: 1904236027

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, minor comments edits I'll commit right-away

src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs Outdated Show resolved Hide resolved
src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs Outdated Show resolved Hide resolved
@baywet baywet enabled auto-merge (squash) January 24, 2024 13:27
@baywet baywet merged commit 51d7b30 into microsoft:vnext Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.