Fix data and type mismatch warning for an example object with a date value#1530
Merged
MaggieKimani1 merged 3 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom Jan 16, 2024
mk/fix-data-and-type-mismatchmicrosoft/OpenAPI.NET:mk/fix-data-and-type-mismatchCopy head branch name to clipboard
Merged
Fix data and type mismatch warning for an example object with a date value#1530MaggieKimani1 merged 3 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom mk/fix-data-and-type-mismatchmicrosoft/OpenAPI.NET:mk/fix-data-and-type-mismatchCopy head branch name to clipboard
MaggieKimani1 merged 3 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
mk/fix-data-and-type-mismatchmicrosoft/OpenAPI.NET:mk/fix-data-and-type-mismatchCopy head branch name to clipboard
Conversation
… date-only or date-time property
|
baywet
approved these changes
Jan 16, 2024
andrueastman
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspects the
TimeOfDayproperty of aDateTimeOffSetvalue in an example object during parsing to determine whether it's adate-onlyordate-timetype.If the time component is exactly midnight(00:00:00) meaning no time has elapsed, we conclude that it is a date-only value hence cast it to an
OpenApiDatetype, otherwise its converted to anOpenApiDateTimeobject.Fixes Data and type mismatch found for example of a referenced schema #1526