Fixes v2 examples serialization in a response object#1524
Merged
MaggieKimani1 merged 20 commits intorelease/2.0.0microsoft/OpenAPI.NET:release/2.0.0from Jan 11, 2024
mk/fix-v2-examples-serializationmicrosoft/OpenAPI.NET:mk/fix-v2-examples-serializationCopy head branch name to clipboard
Merged
Fixes v2 examples serialization in a response object#1524MaggieKimani1 merged 20 commits intorelease/2.0.0microsoft/OpenAPI.NET:release/2.0.0from mk/fix-v2-examples-serializationmicrosoft/OpenAPI.NET:mk/fix-v2-examples-serializationCopy head branch name to clipboard
MaggieKimani1 merged 20 commits intorelease/2.0.0microsoft/OpenAPI.NET:release/2.0.0from
mk/fix-v2-examples-serializationmicrosoft/OpenAPI.NET:mk/fix-v2-examples-serializationCopy head branch name to clipboard
Conversation
…amples-serialization
…pend it to the resulting MediaType object during deserialization
…iaType Examples object when upcasting to V3
baywet
requested changes
Jan 11, 2024
src/Microsoft.OpenApi.Readers/V2/OpenApiResponseDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.Readers/V2/OpenApiResponseDeserializer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
…/microsoft/OpenAPI.NET into mk/fix-v2-examples-serialization
baywet
approved these changes
Jan 11, 2024
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for making the changes!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-examplesduring down-casting from v3 to v2x-examplesin a v2 document to examples in the resulting v3 document during upcastingSnippets
Results to:
And the reverse is also true.