Enable termination of Hidi processes through pressing the breaking key combinations#1108
Merged
MaggieKimani1 merged 7 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom Dec 19, 2022
Merged
Enable termination of Hidi processes through pressing the breaking key combinations#1108MaggieKimani1 merged 7 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
MaggieKimani1 merged 7 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
Conversation
baywet
requested changes
Dec 14, 2022
…ly when an operation is terminated
baywet
requested changes
Dec 19, 2022
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Dec 19, 2022
Member
baywet
left a comment
There was a problem hiding this comment.
thanks for taking in the suggested changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logic to enable process termination by getting an
IConsoleinstance which enables us to listen for the breaking combinationCTRL+Cand using aCancellationTokento register cancellation and abort the process.Fixes #884
Reference: dotnet/command-line-api#1750 (comment)