Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Serialize OpenApiDate values properly to short date#1102

Merged
irvinesunday merged 2 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
is/fix-date-serializationmicrosoft/OpenAPI.NET:is/fix-date-serializationCopy head branch name to clipboard
Dec 8, 2022
Merged

Serialize OpenApiDate values properly to short date#1102
irvinesunday merged 2 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
is/fix-date-serializationmicrosoft/OpenAPI.NET:is/fix-date-serializationCopy head branch name to clipboard

Conversation

@irvinesunday
Copy link
Contributor

Fixes #1101

This PR:

  • Serializes OpenApiDate values to short date.
  • Updates test to validate the above.

baywet
baywet previously approved these changes Dec 6, 2022
Using value 01/01/0001 could be represented as 1/1/0001 in a machine using a different regional format, and thus cause the test to fail
@irvinesunday irvinesunday dismissed stale reviews from millicentachieng and baywet via df68816 December 8, 2022 07:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@irvinesunday irvinesunday enabled auto-merge (squash) December 8, 2022 07:58
@irvinesunday irvinesunday merged commit 1a7392f into vnext Dec 8, 2022
@irvinesunday irvinesunday deleted the is/fix-date-serialization branch December 8, 2022 12:03
Afsalmc pushed a commit to Afsalmc/OpenAPI.NET that referenced this pull request Dec 14, 2022
* Serialize OpenApiDate properly as Date

* Change test date value

Using value 01/01/0001 could be represented as 1/1/0001 in a machine using a different regional format, and thus cause the test to fail
MaggieKimani1 added a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenApiDate values are serialized as DateTime with timestamps

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.