Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

- upgrades to dotnet 7#1072

Merged
baywet merged 5 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
feature/net7microsoft/OpenAPI.NET:feature/net7Copy head branch name to clipboard
Nov 10, 2022
Merged

- upgrades to dotnet 7#1072
baywet merged 5 commits intovnextmicrosoft/OpenAPI.NET:vnextfrom
feature/net7microsoft/OpenAPI.NET:feature/net7Copy head branch name to clipboard

Conversation

@baywet
Copy link
Member

@baywet baywet commented Nov 8, 2022

Signed-off-by: Vincent Biret vibiret@microsoft.com

@baywet
- upgrades to dotnet 7
973cd6d 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet self-assigned this Nov 8, 2022
@baywet baywet enabled auto-merge November 8, 2022 15:26
baywet added 4 commits November 8, 2022 16:16
@baywet
Merge branch 'vnext' into feature/net7
996d853
@baywet
- adds dotnet 6 since ESRP requires it
fb9633d 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Merge branch 'feature/net7' of https://github.com/microsoft/OpenAPI.NET…
82fa72c 
… into feature/net7
@baywet
- switches to dotnet 2 to fix ESRP
8529c42 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Nov 10, 2022

@baywet I'm curious, was ESRP not working with dotnet 6?

@baywet
Copy link
Member Author

baywet commented Nov 10, 2022

Yeah that's what I'm looking into, I think what's actually happening is that net6 "allowed" some older versions, and net7 disables them (even though supported by net6) unless explicitly installed. ESRP is on 2.1....

@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Nov 10, 2022

Yeah that's what I'm looking into, I think what's actually happening is that net6 "allowed" some older versions, and net7 disables them (even though supported by net6) unless explicitly installed. ESRP is on 2.1....

But I see we're using v1.0 of the ESRP code signing task here

OpenAPI.NET/.azure-pipelines/ci-build.yml

Line 194 in 6c994a5

"toolVersion": "1.0"

@baywet
Copy link
Member Author

baywet commented Nov 10, 2022

yeah I'm not sure how the internals of that task work. Effectively what's happening at this point is the task doesn't even start, so I don't believe it has the time to parse the configuration.

@baywet baywet merged commit 02b42e3 into vnext Nov 10, 2022
@baywet baywet deleted the feature/net7 branch November 10, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

1 more reviewer

@MaggieKimani1 MaggieKimani1 MaggieKimani1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baywet @MaggieKimani1
Morty Proxy This is a proxified and sanitized view of the page, visit original site.