Remove return statement to eliminate NullReference exception#1062
Merged
MaggieKimani1 merged 1 commit intovnextmicrosoft/OpenAPI.NET:vnextfrom Nov 7, 2022
mk/better-error-reportingmicrosoft/OpenAPI.NET:mk/better-error-reportingCopy head branch name to clipboard
Merged
Remove return statement to eliminate NullReference exception#1062MaggieKimani1 merged 1 commit intovnextmicrosoft/OpenAPI.NET:vnextfrom mk/better-error-reportingmicrosoft/OpenAPI.NET:mk/better-error-reportingCopy head branch name to clipboard
MaggieKimani1 merged 1 commit intovnextmicrosoft/OpenAPI.NET:vnextfrom
mk/better-error-reportingmicrosoft/OpenAPI.NET:mk/better-error-reportingCopy head branch name to clipboard
Conversation
baywet
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning a null value once an exception is caught and added to the diagnostics object raises a
NullReferenceExceptionas the newschema.Referenceobject created during schema deserialization is assigned a null value when trying to convert the schema into anOpenApiReferenceobject as shown in this snippet.Meanwhile, there's an actual reference object considering a reference pointer is found in the schema. This means that the value of the '$ref' passed is either unsupported or incorrect.
Fixes #1045