Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix: invariant culture for version field#1014

Merged
baywet merged 1 commit intomicrosoft:vnextmicrosoft/OpenAPI.NET:vnextfrom
Ne4to:invarian-culture-fixNe4to/OpenAPI.NET:invarian-culture-fixCopy head branch name to clipboard
Oct 19, 2022
Merged

fix: invariant culture for version field#1014
baywet merged 1 commit intomicrosoft:vnextmicrosoft/OpenAPI.NET:vnextfrom
Ne4to:invarian-culture-fixNe4to/OpenAPI.NET:invarian-culture-fixCopy head branch name to clipboard

Conversation

@Ne4to
Copy link
Contributor

@Ne4to Ne4to commented Sep 19, 2022

Writing version field depends on current system culture
version: '1.13.0' for en-US
version: 1.13.0 for en-GB

existing workaround:
set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT environment variable
https://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization#invariant-mode

Writing version field depends on current system culture
version: '1.13.0' for `en-US`
version: 1.13.0 for `en-GB`

existing workaround:
set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT environment variable
https://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization#invariant-mode
@Ne4to
Copy link
Contributor Author

Ne4to commented Oct 19, 2022

It looks like one of the checks is not able to report status. How can I force to restart the check?

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ne4to Thanks for the contribution.
This check actually won't work for you, compliance policies prevent us from running some of the checks on PRs from forks, let me see how I can unblock this.

@baywet baywet merged commit 86e04ff into microsoft:vnext Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.