From ac2b796672728a2bb1d95b3b07e5b6698840eb4d Mon Sep 17 00:00:00 2001 From: Tom Care Date: Fri, 6 Mar 2020 14:56:22 -0800 Subject: [PATCH 1/2] Add vars template to canary pipeline --- .pipelines/abtest.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.pipelines/abtest.yml b/.pipelines/abtest.yml index 0d64e8c8..9d58fdbb 100644 --- a/.pipelines/abtest.yml +++ b/.pipelines/abtest.yml @@ -18,6 +18,7 @@ trigger: - ml_service/util/smoke_test_scoring_service.py variables: +- template: diabetes_regression-variables-template.yml - group: 'devopsforai-aml-vg' - name: 'helmVersion' value: 'v3.0.1' From b2edabf6f6cf497685eb36ac52948c870b6c9e80 Mon Sep 17 00:00:00 2001 From: Tom Care Date: Mon, 9 Mar 2020 15:16:16 -0700 Subject: [PATCH 2/2] Enable ACR authentication on AKS using a service principal - Upgrade helm version to 3.1.1 - Remove ACR secret from the abtest-model deployment --- .pipelines/abtest.yml | 2 +- charts/abtest-model/templates/deployment.yaml | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.pipelines/abtest.yml b/.pipelines/abtest.yml index 9d58fdbb..cf876181 100644 --- a/.pipelines/abtest.yml +++ b/.pipelines/abtest.yml @@ -21,7 +21,7 @@ variables: - template: diabetes_regression-variables-template.yml - group: 'devopsforai-aml-vg' - name: 'helmVersion' - value: 'v3.0.1' + value: 'v3.1.1' - name: 'helmDownloadURL' value: 'https://get.helm.sh/helm-$HELM_VERSION-linux-amd64.tar.gz' - name: 'blueReleaseName' diff --git a/charts/abtest-model/templates/deployment.yaml b/charts/abtest-model/templates/deployment.yaml index 13572b36..78d01cc4 100644 --- a/charts/abtest-model/templates/deployment.yaml +++ b/charts/abtest-model/templates/deployment.yaml @@ -27,5 +27,4 @@ spec: containerPort: 5001 - name: probe containerPort: 8086 - imagePullSecrets: - - name: aks-secret +