Show "No results" empty state in Metric Viewer #73705
Draft
AndreyChernykh wants to merge 3 commits intomastermetabase/metabase:masterfrom
uxw-3906-metric-viewer-should-use-existing-no-results-statemetabase/metabase:uxw-3906-metric-viewer-should-use-existing-no-results-stateCopy head branch name to clipboard
Draft
Show "No results" empty state in Metric Viewer #73705AndreyChernykh wants to merge 3 commits intomastermetabase/metabase:masterfrom uxw-3906-metric-viewer-should-use-existing-no-results-statemetabase/metabase:uxw-3906-metric-viewer-should-use-existing-no-results-stateCopy head branch name to clipboard
AndreyChernykh wants to merge 3 commits intomastermetabase/metabase:masterfrom
uxw-3906-metric-viewer-should-use-existing-no-results-statemetabase/metabase:uxw-3906-metric-viewer-should-use-existing-no-results-stateCopy head branch name to clipboard
Conversation
Contributor
e2e tests failed on
|
| File | Test Name |
|---|---|
metrics-explorer.cy.spec.ts |
scenarios > metrics > explorer > Adding metrics and measures > should add metrics and measures from the entity picker |
metrics-explorer.cy.spec.ts |
scenarios > metrics > explorer > Adding metrics and measures > should add multiple metrics one by one using metrics dropdown |
model-actions.cy.spec.js |
Write actions on model detail page (postgres) > should respect impersonated permission |
source-replacement.cy.spec.ts |
scenarios > data-studio > source replacement > Native queries > replaces a table referenced in a native SQL question |
usage-auditing.cy.spec.ts |
scenarios > metabot > usage auditing > drills through from the conversations by day chart to the conversations list |
usage-auditing.cy.spec.ts |
scenarios > metabot > usage auditing > drills through from the conversations by hour chart to the conversations list |
usage-auditing.cy.spec.ts |
scenarios > metabot > usage auditing > uses hourly stats for a single-day date filter |
query-external.cy.spec.js |
scenarios > question > query > external > can query Mongo database |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes UXW-3906.
When all series in the Metric Viewer have zero rows (e.g. a filter excludes everything), render the same chill-mode "No results!" empty state used by the question viewer instead of the per-visualization
MinRowsErrorwarning. The warning was misleading — zero rows from filters isn't a visualization configuration problem.How to verify
Total >= 999999999).Demo
Before
After
Checklist