Demonstrate WebSocket transport#998
Open
WillerZ wants to merge 1 commit intomeshtastic:mainmeshtastic/web:mainfrom
Open
Demonstrate WebSocket transport#998WillerZ wants to merge 1 commit intomeshtastic:mainmeshtastic/web:mainfrom
WillerZ wants to merge 1 commit intomeshtastic:mainmeshtastic/web:mainfrom
Conversation
|
|
|
@WillerZ is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR gives the capability for the Web UI to connect to nodes which have a serial interface attached to some other server.
The server with the node attached needs to expose the serial port as a WebSocket. Some software to do this is at https://github.com/WillerZ/ws-serial-gateway
It's not my expectation that you would want to merge this PR in its current state, and it is not my intent to do any further work on this. The point of this PR is to let you know that it's possible, so that you can assess whether it is a feature that you want to incorporate.
My assessment of the code in this PR is that the transport code is near-complete and works as far as I can test it in the real world. The UI changes are a total mess and should probably be discarded and re-done by a React afficionado.
Changes Made
Testing Done
Reused transport tests.
Manually tested that I can connect to, view the config, change the config, and send messages from a node attached through the WebSocket transport.
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)