Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix Issue 2791: Implement toFloatList() #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
Loading
from
Open

Fix Issue 2791: Implement toFloatList() #3318

wants to merge 2 commits into from

Conversation

ChandrapalSd
Copy link

Implemented the toFloatList, toBooleanList, and toIntegerList functions, and added basic unit tests for each.

@ChandrapalSd
Copy link
Author

ChandrapalSd commented Oct 3, 2025 •
edited by colinbarry
Loading

Tracking

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • What has changed? What does it mean for a user? What should a user do with it? [#{{PR_number}}]({{link to the PR}})
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR

@ChandrapalSd ChandrapalSd marked this pull request as ready for review October 3, 2025 19:12
@ChandrapalSd
Copy link
Author

Please review this PR and let me know if the implementation is correct or if any changes are needed.
Thank you for your time and feedback!

@antejavor antejavor linked an issue Oct 6, 2025 that may be closed by this pull request
Implement toFloatList() #2791
Open
@colinbarry colinbarry self-requested a review October 6, 2025 08:55
@colinbarry colinbarry added CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=coverage -test=clang_tidy feature feature labels Oct 6, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ChandrapalSd
❌ colinbarry
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@colinbarry
Copy link
Contributor

Hello @ChandrapalSd. Thank you for the contribution. It is in my review queue, and I will get back to you as soon as possible with feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colinbarry colinbarry Awaiting requested review from colinbarry

At least 1 approving review is required to merge this pull request.

Assignees

@ChandrapalSd ChandrapalSd

Labels

CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=clang_tidy CI -build=coverage -test=core Run coverage build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push feature feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement toFloatList()

3 participants

@ChandrapalSd @CLAassistant @colinbarry
Morty Proxy This is a proxified and sanitized view of the page, visit original site.