-
Notifications
You must be signed in to change notification settings - Fork 827
Boot: Zephyr: Boards: Fix STM32H750B-DK App in Ext Flash support #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@nordicjm all tests are passing in zephyrproject-rtos/zephyr#97037, this PR is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but aim is to get rid of this asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late catch, sorry (but as I understood there will be anyway some changes needed).
Instead of using <board>_<file_suffix>
, let's move to <soc>_<file_suffix>
already since it will save us from some duplication (and allow other (out of tree) H750xx users to benefit from this)
2a84c8c
to
7dd148c
Compare
Following the introduction of stm32h750b-dk 'ext_flash_app' board variant, for storing apps in external Flash and chainloading them with MCUboot that's placed in internal Flash, we need a DT overlay to designate internal Flash & controller as the chosen 'zephyr,flash' & 'zephyr,flash-controller' for the MCUboot Zephyr Application. BOOT_MAX_IMG_SECTORS_AUTO no longer need to be disabled after including the 'soc-nv-flash' compatible in the board's external flash node, & declaring the 'erase-block-size' & 'write-block-size' properties. Signed-off-by: Abderrahmane JARMOUNI <git@jarmouni.me>
7dd148c
to
94960b9
Compare
Following the introduction of stm32h750b-dk 'ext_flash_app' board variant (zephyrproject-rtos/zephyr#97037), for storing apps in external Flash and chainloading them with MCUboot that's placed in internal Flash, we need a DT overlay to designate internal Flash & controller as the chosen 'zephyr,flash' & 'zephyr,flash-controller' for the MCUboot Zephyr Application. This way, no DT overlay will be needed at the Zephyr user app level.
Also, remove board conf file, as enabling STM32_MEMMAP is no longer needed here since it is now set on the Zephyr side in the board's 'Kconfig.defconfig' when building MCUboot app. And BOOT_MAX_IMG_SECTORS_AUTO no longer need to be disabled, after including the 'soc-nv-flash' binding in the 'st,stm32-qspi-nor' binding, then adding the 'erase-block-size' & 'write-block-size' properties in external Flash DT node.