feat(ScheduleFinderLive): use visibilitychange (closes #3125)#3144
Merged
thecristen merged 2 commits intomainmbta/dotcom:mainfrom Apr 29, 2026
Merged
feat(ScheduleFinderLive): use visibilitychange (closes #3125)#3144thecristen merged 2 commits intomainmbta/dotcom:mainfrom
thecristen merged 2 commits intomainmbta/dotcom:mainfrom
Conversation
lvachon1
reviewed
Apr 29, 2026
lvachon1
approved these changes
Apr 29, 2026
Contributor
lvachon1
left a comment
There was a problem hiding this comment.
This is great! Thanks for taking my half-baked idea over the line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Builds off prior art:
Implementation
visibilitychangeevent listener. It pushes the documentvisibilityStateto the server, which can be handled in the parent LiveView viahandle_event.visibilityStatevisibilityStatedestroyed()we remove the event listener.Then I edited the Schedule Finder to respond to the changed value:
:should_refresh?, which iftruewill schedule (ahem) the next upcoming departure update.How to test
I put an
IO.inspect()inassign_upcoming_departures/1to see how frequently it's being called after changing the tab visibility state! I'll note it's not a perfect/immediate transition - for example, if the next upcoming departure update is already queued when the tab changes to a hidden state, that next update will still happen.