Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Fix pin/unpin slowness and non refresh from the message action bar #12934

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Fix pin/unpin slowness and non refresh from the message action bar #12934

merged 5 commits into from
Aug 28, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 27, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

This PR:

  • Improve doc of PinningUtils
  • Use the PinningUtils.isPinnable instead of canPinEvent in order to use the same function to determine if an event is pinnable.
  • Parallelize promises in order to reduce the slowness of the pin action
  • Fix the pin/unpin icon is not updated in the message action bar when clicked. Rerender the message action bar if there is a change in room pinned events.

@florianduros florianduros added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Aug 27, 2024
@florianduros florianduros force-pushed the florianduros/pinned-messages/fix-pin branch from 17346ce to 5dae313 Compare August 27, 2024 15:15
@florianduros florianduros marked this pull request as ready for review August 27, 2024 16:29
@florianduros florianduros requested a review from a team as a code owner August 27, 2024 16:29
@florianduros florianduros added this pull request to the merge queue Aug 28, 2024
Merged via the queue into develop with commit ea3c5cf Aug 28, 2024
@florianduros florianduros deleted the florianduros/pinned-messages/fix-pin branch August 28, 2024 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

1 more reviewer

@dbkr dbkr dbkr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florianduros @dbkr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.