Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Aug 16, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Related to https://github.com/element-hq/element-internal/issues/607.
Figma https://www.figma.com/design/nwbnk8RaZctjrrRGTUcx1X/Pinned-Messages?node-id=38-170276&t=QMMsCWBcCSoSiyn5-0

  • Add pin/unpin action in quick access of the message action bar
  • Use new pin/unpin icon
  • Pin/unpin is available in the context menu of the message action bar only when right clicked (same behaviour than edit, threads etc)
  • Move pinning function from context menu to PinningUtils
Before After
Screenshot 2024-08-19 at 15 33 29 Screenshot 2024-08-19 at 15 31 20
Screenshot 2024-08-19 at 15 33 50 Screenshot 2024-08-19 at 15 31 32
Screenshot 2024-08-19 at 15 34 07 Screenshot 2024-08-19 at 15 31 58

@florianduros florianduros added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 16, 2024
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Good, thorough set of tests.

test/components/views/messages/MessageActionBar-test.tsx Outdated Show resolved Hide resolved
test/components/views/messages/MessageActionBar-test.tsx Outdated Show resolved Hide resolved
test/utils/PinningUtils-test.ts Outdated Show resolved Hide resolved
Merged via the queue into develop with commit 3d80eff Aug 21, 2024
@florianduros florianduros deleted the florianduros/pinned-messages/message-action-bar branch August 21, 2024 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.