This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Rename general user settings to account #12841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything 'general' is now elsewhere, so this is ready for its new name.
|
Sonarclud wants the renamed file to be up to test coverage, which admittedly it ought to be anyway, so I'm going to put this on ice while I sort the thing out, convert it to functional etc. |
robintown
reviewed
Aug 2, 2024
test/components/views/settings/tabs/user/AccountUserSettingsTab-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/settings/tabs/user/AccountUserSettingsTab-test.tsx
Outdated
Show resolved
Hide resolved
robintown
approved these changes
Aug 2, 2024
|
mmm, would like to but it'll involve making the TabbedView icons support compound design tokens, so probably ought to be in its own PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything 'general' is now elsewhere, so this is ready for its new name.
This still needed a bunch of tests adding, so that's about half the content of this PR.
Checklist
public/exportedsymbols have accurate TSDoc documentation.