Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

FIX: treat zorder=None as falling back to the default #9793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

tacaswell
Copy link
Member

closes #9785

PR Summary

If set_zorder gets None as input, fall back to the class level zorder (the default).

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant

@tacaswell tacaswell added this to the v2.1.1 milestone Nov 16, 2017
@jklymak
Copy link
Member

jklymak commented Nov 16, 2017

Are grid lines Artists?

@tacaswell
Copy link
Member Author

Everything that shows up in the final figure is an artist (eventually) http://matplotlib.org/api/artist_api.html iirc, the grid lines are drawn as part of the Tick classes.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@efiring efiring merged commit c66c423 into matplotlib:v2.1.x Nov 16, 2017
@tacaswell tacaswell deleted the fix_none_zorder branch November 20, 2017 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.