Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

blocking_input: Fix "manager" attr check #9759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2017
Merged

blocking_input: Fix "manager" attr check #9759

merged 1 commit into from
Nov 13, 2017

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Nov 12, 2017 •
edited
Loading

PR Summary

Fixes #9758, so now plt.ginput will properly show the plot again. This copies the check from

matplotlib/lib/matplotlib/figure.py

Lines 419 to 425 in 7252158

try:
manager = getattr(self.canvas, 'manager')
except AttributeError as err:
raise AttributeError("%s\n"
"Figure.show works only "
"for figures managed by pyplot, normally "
"created by pyplot.figure()." % err)

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Nov 12, 2017
@anntzer anntzer added this to the v2.1.1 milestone Nov 12, 2017
@efiring efiring merged commit 0827434 into matplotlib:master Nov 13, 2017
lumberbot-app bot pushed a commit that referenced this pull request Nov 13, 2017
@efiring
Backport PR #9759: blocking_input: Fix "manager" attr check
47602d5
@lumberbot-app lumberbot-app bot mentioned this pull request Nov 13, 2017
Merged
@efiring
Copy link
Member

efiring commented Nov 13, 2017

Thank you, @mc10, for your first mpl contribution!

@kevinji kevinji deleted the patch-1 branch November 13, 2017 06:14
dstansby added a commit that referenced this pull request Nov 13, 2017
@dstansby
Merge pull request #9762 from matplotlib/auto-backport-of-pr-9759
3aa2436 
Backport PR #9759 on branch v2.1.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinji @efiring @anntzer
Morty Proxy This is a proxified and sanitized view of the page, visit original site.