Fix lorenz_attractor example on Python 3 #969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging. |
mdboom
added a commit
that referenced
this pull request
Jun 28, 2012
Fix lorenz_attractor example on Python 3
|
I don't have a problem with this change, but it does brings up an interesting question about the python3 ability of the examples. A quick 2to3 on them shows that there are a host of (automatable) changes needed, but that would obviously break the python2 support. Is there any strategy on this issue? |
|
Almost all examples can run unchanged under Python 2 and 3 without the need to run 2to3. I vote for fixing the examples that fail. |
|
To comment on the strategy: The plan (for now) is to require 2to3 on code in the matplotlib library itself, and write simpler cross-version code for all of the examples. Many of the examples were tested under Python3 at some point -- some may have been missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.