Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Implement Qt4 backend by fully reexporting Qt5 backend. #9641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

Implement Qt4 backend by fully reexporting Qt5 backend. #9641

merged 1 commit into from
Dec 13, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 31, 2017

PR Summary

All's in the title: transform the Qt4 backend into a thin shell that just reexports everything from the Qt5 backend.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v2.2 milestone Oct 31, 2017
@anntzer anntzer mentioned this pull request Dec 13, 2017
Closed
@fariza
Copy link
Member

fariza commented Dec 13, 2017

The decision tree is not working properly

I have pyside installed, and 4/5 work (5 shoulnd't work)
If I install sip, then neither 4/5 works (import error PyQtx), but I still have pyside installed, so they must work
If I install pyqtx then starts working

@tacaswell
Copy link
Member

@fariza I think that is more of a problem in the qt_compat than with this?

@fariza
Copy link
Member

fariza commented Dec 13, 2017

sorry, my bad

@fariza fariza merged commit a890573 into matplotlib:master Dec 13, 2017
@tacaswell
Copy link
Member

@fariza No worries!

@anntzer anntzer deleted the qt4-as-qt5 branch December 13, 2017 16:45
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
GUI: Qt
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @fariza @tacaswell @dopplershift @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.